clintropolis commented on code in PR #19496:
URL: https://github.com/apache/druid/pull/19496#discussion_r3283215436
##########
processing/src/main/java/org/apache/druid/segment/file/SegmentFileContainerMetadata.java:
##########
@@ -30,30 +31,29 @@
* Starting offset and size of a 'container' stored in a V10 segment file;
think the V10 equivalent of V9's external
* 'smoosh' files, e.g. 00000.smoosh.
* <p>
- * Each container holds internal files belonging to at most one named file
group, as declared at write time via
- * {@link SegmentFileBuilder#startFileGroup}. The {@link #fileGroup} field
records that name so readers can attribute
- * a container to its group without parsing internal-file names. The field is
{@code null} for containers written
- * without a {@code startFileGroup} call (or with {@code
startFileGroup(null)}), and for containers from segments
- * produced by writers that pre-date this field; null serializes as a
Jackson-omitted property so old segments
- * round-trip unchanged.
+ * Each container holds internal files belonging to exactly one named bundle,
as declared at write time via
+ * {@link SegmentFileBuilder#startFileBundle}. The {@link #bundle} field
records that name so readers can attribute a
+ * container to its bundle without parsing internal-file names. Containers
written without an explicit
+ * {@code startFileBundle} call are tagged with {@link
SegmentFileBuilder#ROOT_BUNDLE_NAME}; that default value is
+ * omitted from JSON output, so segments produced by writers pre-dating this
field deserialize cleanly (missing
+ * property normalizes to the default in the constructor).
*/
public class SegmentFileContainerMetadata
{
private final long startOffset;
private final long size;
- @Nullable
- private final String fileGroup;
+ private final String bundle;
@JsonCreator
public SegmentFileContainerMetadata(
@JsonProperty("startOffset") long startOffset,
@JsonProperty("size") long size,
- @JsonProperty("fileGroup") @Nullable String fileGroup
+ @JsonProperty("bundle") @Nullable String bundle
Review Comment:
I added this a few days ago in #19468, so it hasn't been officially released
yet, just renaming it here to have more consistent naming between stuff. Also,
if any segments written with `fileGroup` happen to exist, they will still work
more or less properly, they will just fallback to behaving as older segments
written prior to that, where all containers will just have a single 'bundle'
when used with partial downloads, which I think is ok (V10 is not on by default
yet).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
