jtuglu1 commented on issue #19505: URL: https://github.com/apache/druid/issues/19505#issuecomment-4517125689
> but this does suggest that we may benefit from introducing more systematic benchmarking for future PRs that could affect query or ingestion performance. +1 here. I have spoken to @clintropolis about this before. IMO the current problem with the benchmarks/ is that there is no standard format/max runtime to the benchmarks, which makes it hard to run automatically. Do you think you could put together a format for benchmarks that we could run on every PR? Ideally, these would be microbenchmarks (e.g < XXs runtime). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
