gianm commented on issue #5789: Add stringLast and stringFirst aggregators 
extension
URL: https://github.com/apache/incubator-druid/pull/5789#issuecomment-471811527
 
 
   @glasser Hmm, I just noticed the AggregateCombiner type is a 
`ObjectAggregateCombiner<String>`. I would think it should be a 
SerializablePairLongString. I wonder if the combiner just plain doesn't work, 
and the reason the repro doesn't trigger this is because it is loading too 
little data and doesn't actually need to combine anything from two different 
spill files (I believe that's when AggregateCombiners are used).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to