github-advanced-security[bot] commented on code in PR #19530:
URL: https://github.com/apache/druid/pull/19530#discussion_r3321521610
##########
server/src/test/java/org/apache/druid/client/selector/ServerSelectorTest.java:
##########
@@ -168,4 +174,100 @@
Assert.assertTrue(selector.hasData());
}
+ @Test
+ public void testExcludeSourceDoesNotUseRealtimeFallback()
+ {
+ final DataSegment segment = dataSegment();
+ final QueryableDruidServer realtimeServer = queryableServer("realtime",
ServerType.INDEXER_EXECUTOR);
+ final ServerSelector selector = new ServerSelector(
+ segment,
+ new HighestPriorityTierSelectorStrategy(new
RandomServerSelectorStrategy()),
+ HistoricalFilter.IDENTITY_FILTER
+ );
+ selector.addServerAndUpdateSegment(realtimeServer, segment);
+
+ Assert.assertNull(selector.pick(null, CloneQueryMode.EXCLUDESOURCE));
+ Assert.assertEquals(List.of(), selector.getCandidates(1,
CloneQueryMode.EXCLUDESOURCE));
+ Assert.assertEquals(List.of(),
selector.getAllServers(CloneQueryMode.EXCLUDESOURCE));
+ Assert.assertEquals(realtimeServer, selector.pick(null,
CloneQueryMode.EXCLUDECLONES));
+ }
+
+ @Test
+ public void testExcludeSourceDoesNotAddRealtimeCandidates()
+ {
+ final DataSegment segment = dataSegment();
+ final QueryableDruidServer cloneServer = queryableServer("clone",
ServerType.HISTORICAL);
+ final QueryableDruidServer sourceServer = queryableServer("source",
ServerType.HISTORICAL);
+ final QueryableDruidServer realtimeServer = queryableServer("realtime",
ServerType.INDEXER_EXECUTOR);
+ final ServerSelector selector = new ServerSelector(
+ segment,
+ new HighestPriorityTierSelectorStrategy(new
RandomServerSelectorStrategy()),
+ ServerSelectorTest::cloneOnlyFilter
+ );
+ selector.addServerAndUpdateSegment(cloneServer, segment);
+ selector.addServerAndUpdateSegment(sourceServer, segment);
+ selector.addServerAndUpdateSegment(realtimeServer, segment);
+
+ Assert.assertEquals(cloneServer, selector.pick(null,
CloneQueryMode.EXCLUDESOURCE));
+ Assert.assertEquals(
+ List.of(cloneServer.getServer().getMetadata()),
+ selector.getCandidates(3, CloneQueryMode.EXCLUDESOURCE)
+ );
+ Assert.assertEquals(
+ List.of(cloneServer.getServer().getMetadata()),
+ selector.getAllServers(CloneQueryMode.EXCLUDESOURCE)
+ );
+ }
+
+ private static Int2ObjectRBTreeMap<Set<QueryableDruidServer>>
cloneOnlyFilter(
+ final Int2ObjectRBTreeMap<Set<QueryableDruidServer>> historicalServers,
+ final CloneQueryMode mode
+ )
+ {
+ if (mode != CloneQueryMode.EXCLUDESOURCE) {
+ return historicalServers;
+ }
+
+ final Int2ObjectRBTreeMap<Set<QueryableDruidServer>> filteredHistoricals =
new Int2ObjectRBTreeMap<>();
+ for (final int priority : historicalServers.keySet()) {
+ filteredHistoricals.put(
+ priority,
+ historicalServers.get(priority)
+ .stream()
+ .filter(server ->
"clone".equals(server.getServer().getHost()))
+ .collect(Collectors.toSet())
+ );
+ }
+ return filteredHistoricals;
+ }
+
+ private static QueryableDruidServer queryableServer(final String host, final
ServerType serverType)
+ {
+ return new QueryableDruidServer(
+ new DruidServer(host, host, null, 0, null, serverType,
DruidServer.DEFAULT_TIER, 1),
+ EasyMock.createMock(DirectDruidClient.class)
+ );
+ }
+
+ private static DataSegment dataSegment()
+ {
+ return DataSegment.builder()
Review Comment:
## CodeQL / Deprecated method or constructor invocation
Invoking [DataSegment.builder](1) should be avoided because it has been
deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11259)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
