gianm commented on a change in pull request #7234: lifecycle stage refactor to 
ensure proper start and stop ordering of servers and announcements
URL: https://github.com/apache/incubator-druid/pull/7234#discussion_r264509219
 
 

 ##########
 File path: 
extensions-contrib/materialized-view-selection/src/main/java/org/apache/druid/query/materializedview/DerivativeDataSourceManager.java
 ##########
 @@ -65,7 +65,7 @@
  * Read and store derivatives information from dataSource table frequently.
  * When optimize query, DerivativesManager offers the information about 
derivatives.
  */
-@ManageLifecycleLast
+@ManageLifecycleAnnouncements
 
 Review comment:
   Why is this in `@ManageLifecycleAnnouncements`? It doesn't seem to be doing 
announcements?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to