jtuglu1 commented on code in PR #19525:
URL: https://github.com/apache/druid/pull/19525#discussion_r3327730864
##########
extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/KafkaSamplerSpec.java:
##########
@@ -69,8 +69,12 @@ protected KafkaRecordSupplier createRecordSupplier()
props.put("request.timeout.ms",
Integer.toString(samplerConfig.getTimeoutMs()));
KafkaSupervisorIOConfig kafkaSupervisorIOConfig =
(KafkaSupervisorIOConfig) ioConfig;
- return new KafkaRecordSupplier(props, objectMapper,
kafkaSupervisorIOConfig.getConfigOverrides(),
- kafkaSupervisorIOConfig.isMultiTopic()
+ return new KafkaRecordSupplier(
+ props,
+ objectMapper,
+ kafkaSupervisorIOConfig.getConfigOverrides(),
+ kafkaSupervisorIOConfig.isMultiTopic(),
+ null
Review Comment:
Do we even want to emit metrics for sampler specs? Can we treat `null` as
don't actually emit anything?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
