clintropolis commented on a change in pull request #7234: lifecycle stage refactor to ensure proper start and stop ordering of servers and announcements URL: https://github.com/apache/incubator-druid/pull/7234#discussion_r264514103
########## File path: extensions-contrib/materialized-view-selection/src/main/java/org/apache/druid/query/materializedview/DerivativeDataSourceManager.java ########## @@ -65,7 +65,7 @@ * Read and store derivatives information from dataSource table frequently. * When optimize query, DerivativesManager offers the information about derivatives. */ -@ManageLifecycleLast +@ManageLifecycleAnnouncements Review comment: There is no reason in the initial PR, it was already in the first commit and not an explicit response to review afaict. Looking over what it is doing, it doesn't seem like it would need to be in the last stage, I will move it to just `@ManageLifecycle` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
