clintropolis commented on code in PR #19561:
URL: https://github.com/apache/druid/pull/19561#discussion_r3364440270
##########
benchmarks/src/test/java/org/apache/druid/benchmark/query/SqlExpressionBenchmark.java:
##########
@@ -50,7 +50,7 @@ public class SqlExpressionBenchmark extends
SqlBaseQueryBenchmark
// non-expression reference queries
// ===========================
// 0: non-expression timeseries reference, 1 columns
- "SELECT SUM(long1) FROM expressions",
+ "SELECT SUM(long5) FROM expressions",
Review Comment:
oh i can revert it, its mentioned in the PR description that I changed it
because long1 has no nulls and long5 has a bunch of them, so they exercise
different paths
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
