aho135 commented on code in PR #19571:
URL: https://github.com/apache/druid/pull/19571#discussion_r3384807547


##########
docs/ingestion/kafka-ingestion.md:
##########
@@ -126,6 +126,7 @@ For configuration properties shared across all streaming 
ingestion methods, refe
 |`pollTimeout`|Long|The length of time to wait for the Kafka consumer to poll 
records, in milliseconds.|No|100|
 |`useEarliestOffset`|Boolean|If a supervisor is managing a datasource for the 
first time, it obtains a set of starting offsets from Kafka. This flag 
determines whether the supervisor retrieves the earliest or latest offsets in 
Kafka. Under normal circumstances, subsequent tasks start from where the 
previous segments ended so this flag is only used on the first run.|No|`false`|
 |`idleConfig`|Object|Defines how and when the Kafka supervisor can become 
idle. See [Idle configuration](#idle-configuration) for more details.|No|null|
+|`partitionFilterDimensions`|List of String|Dimensions to track for query-time 
segment pruning. See [Partition filter 
dimensions](#partition-filter-dimensions) for details.|No|null|

Review Comment:
   What do you think about naming this `partitionDimensions` to align with the 
compaction config? That may make it more clear that those values should be in 
sync



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to