clintropolis commented on code in PR #19565:
URL: https://github.com/apache/druid/pull/19565#discussion_r3385442405
##########
server/src/main/java/org/apache/druid/server/coordinator/rules/ClusterGroupPartialLoadMatcher.java:
##########
@@ -59,10 +78,13 @@ public MatchResult match(DataSegment segment, Map<String,
Object> baseLoadSpec)
return null;
}
final List<Integer> resolved = resolveClusterGroupIndices(segment);
- if (resolved.isEmpty()) {
+ final ShardSpec shardSpec = segment.getShardSpec();
+ if (resolved.isEmpty() && shardSpec.getPartitionNum() >=
shardSpec.getNumCorePartitions()) {
+ // No patterns match and this segment isn't part of a core partition
group, so no need for an empty load. Fall
+ // through to the cannot-match handling.
return null;
}
- final String fingerprint = computeFingerprint(resolved);
+ final String fingerprint = resolved.isEmpty() ? EMPTY_LOAD_FINGERPRINT :
computeFingerprint(resolved);
Review Comment:
actually still a problem here i think, trying to figure out the best thing
to do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
