Fly-Style commented on code in PR #19568:
URL: https://github.com/apache/druid/pull/19568#discussion_r3389180634
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/supervisor/SupervisorManager.java:
##########
@@ -615,12 +625,10 @@ private SupervisorSpec
possiblyStopAndRemoveSupervisorInternal(String id, boolea
}
if (writeTombstone) {
- metadataSupervisorManager.insert(
- id,
- new NoopSupervisorSpec(null, pair.rhs.getDataSources())
- ); // where NoopSupervisorSpec is a tombstone
+ // NoopSupervisorSpec is a tombstone
+ metadataSupervisorManager.insert(id, new NoopSupervisorSpec(null,
pair.rhs.getDataSources()));
}
- pair.lhs.stop(true);
+ pair.lhs.stop(pair.lhs.stopGracefullyOnNewSpec());
Review Comment:
Addressed, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
