clintropolis commented on code in PR #19535:
URL: https://github.com/apache/druid/pull/19535#discussion_r3415395921
##########
multi-stage-query/src/main/java/org/apache/druid/msq/input/RegularLoadableSegment.java:
##########
@@ -140,7 +140,7 @@ public synchronized Optional<Segment> acquireIfCached()
throw DruidException.defensive("Segment with descriptor[%s] is already
acquired", descriptor);
}
- final Optional<Segment> cachedSegment =
segmentManager.acquireCachedSegment(segmentId);
+ final Optional<Segment> cachedSegment =
segmentManager.acquireCachedPartialSegment(segmentId);
Review Comment:
this now accepts the `AcquireMode` enum argument to pass through, and the
engine decides what mode it wants when creating the `ReadableInputQueue` (see
`BaseLeafStageProcessor.makeReadableInputQueue`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
