This is an automated email from the ASF dual-hosted git repository.

abhishekrb19 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git


The following commit(s) were added to refs/heads/master by this push:
     new ed63f731e13 test: Hoist latch-timeout override to 
StreamIndexFaultToleranceTest to reduce flakiness (#19580)
ed63f731e13 is described below

commit ed63f731e1360d981a975dbe2bc01435b5dc9cc0
Author: Andreas Maechler <[email protected]>
AuthorDate: Mon Jun 15 14:33:56 2026 -0600

    test: Hoist latch-timeout override to StreamIndexFaultToleranceTest to 
reduce flakiness (#19580)
    
    KafkaIndexFaultToleranceTest inherited the 60s LatchableEmitter default from
    StreamIndexTestBase and intermittently timed out ("Timed out waiting for 
event
    after [60,000]ms") when the shared CI runner was under load. 
KinesisFaultToleranceTest
    already worked around this with a 120s override; move that override into 
the shared
    StreamIndexFaultToleranceTest base so both stream fault-tolerance suites 
inherit it,
    and drop the now-redundant per-subclass overrides.
---
 .../embedded/indexing/StreamIndexFaultToleranceTest.java     | 12 ++++++++++++
 .../testing/embedded/kinesis/KinesisFaultToleranceTest.java  |  7 -------
 2 files changed, 12 insertions(+), 7 deletions(-)

diff --git 
a/embedded-tests/src/test/java/org/apache/druid/testing/embedded/indexing/StreamIndexFaultToleranceTest.java
 
b/embedded-tests/src/test/java/org/apache/druid/testing/embedded/indexing/StreamIndexFaultToleranceTest.java
index 542b479b416..89219c58317 100644
--- 
a/embedded-tests/src/test/java/org/apache/druid/testing/embedded/indexing/StreamIndexFaultToleranceTest.java
+++ 
b/embedded-tests/src/test/java/org/apache/druid/testing/embedded/indexing/StreamIndexFaultToleranceTest.java
@@ -24,6 +24,7 @@ import 
org.apache.druid.indexing.overlord.supervisor.SupervisorSpec;
 import org.apache.druid.java.util.common.StringUtils;
 import org.apache.druid.query.DruidMetrics;
 import org.apache.druid.rpc.RequestBuilder;
+import org.apache.druid.testing.embedded.EmbeddedDruidCluster;
 import org.apache.druid.testing.embedded.StreamIngestResource;
 import org.jboss.netty.handler.codec.http.HttpMethod;
 import org.junit.jupiter.api.AfterEach;
@@ -44,6 +45,17 @@ public abstract class StreamIndexFaultToleranceTest extends 
StreamIndexTestBase
 
   private StreamIngestResource<?> streamResource;
 
+  /**
+   * Publishing all ingested rows can exceed the 60s {@link 
StreamIndexTestBase}
+   * default when the CI runner is busy, so match the longer timeout the 
Kinesis
+   * sibling already uses.
+   */
+  @Override
+  protected EmbeddedDruidCluster createCluster()
+  {
+    return super.createCluster().useDefaultTimeoutForLatchableEmitter(120);
+  }
+
   @BeforeEach
   public void setupTopicAndSupervisor()
   {
diff --git 
a/embedded-tests/src/test/java/org/apache/druid/testing/embedded/kinesis/KinesisFaultToleranceTest.java
 
b/embedded-tests/src/test/java/org/apache/druid/testing/embedded/kinesis/KinesisFaultToleranceTest.java
index 4725db58890..8bfa9836f67 100644
--- 
a/embedded-tests/src/test/java/org/apache/druid/testing/embedded/kinesis/KinesisFaultToleranceTest.java
+++ 
b/embedded-tests/src/test/java/org/apache/druid/testing/embedded/kinesis/KinesisFaultToleranceTest.java
@@ -20,7 +20,6 @@
 package org.apache.druid.testing.embedded.kinesis;
 
 import org.apache.druid.indexing.overlord.supervisor.SupervisorSpec;
-import org.apache.druid.testing.embedded.EmbeddedDruidCluster;
 import org.apache.druid.testing.embedded.StreamIngestResource;
 import 
org.apache.druid.testing.embedded.indexing.StreamIndexFaultToleranceTest;
 import org.junit.jupiter.api.BeforeEach;
@@ -63,12 +62,6 @@ public class KinesisFaultToleranceTest extends 
StreamIndexFaultToleranceTest
     return createKinesisSupervisor(kinesis, dataSource, topic);
   }
 
-  @Override
-  protected EmbeddedDruidCluster createCluster()
-  {
-    return super.createCluster().useDefaultTimeoutForLatchableEmitter(120);
-  }
-
   @Test
   public void test_supervisorRecovers_afterCoordinatorRestart() throws 
Exception
   {


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to