rinchinov commented on code in PR #19592:
URL: https://github.com/apache/druid/pull/19592#discussion_r3436159512
##########
extensions-contrib/druid-deltalake-extensions/src/main/java/org/apache/druid/delta/input/DeltaInputSourceReader.java:
##########
@@ -111,20 +118,20 @@ public DeltaInputSourceIterator(
public boolean hasNext()
{
while (currentBatch == null || !currentBatch.hasNext()) {
- if (!filteredColumnarBatchIterators.hasNext()) {
- return false; // No more batches or records to read!
- }
-
- final io.delta.kernel.utils.CloseableIterator<FilteredColumnarBatch>
filteredBatchIterator =
- filteredColumnarBatchIterators.next();
-
- while (filteredBatchIterator.hasNext()) {
- final FilteredColumnarBatch nextBatch = filteredBatchIterator.next();
+ // Drain remaining batches from the current file before moving to the
next.
+ while (currentFileIterator != null && currentFileIterator.hasNext()) {
+ final FilteredColumnarBatch nextBatch = currentFileIterator.next();
currentBatch = nextBatch.getRows();
if (currentBatch.hasNext()) {
return true;
}
}
+
+ // Advance to the next file.
+ if (!filteredColumnarBatchIterators.hasNext()) {
+ return false;
+ }
+ currentFileIterator = filteredColumnarBatchIterators.next();
Review Comment:
thanks for mentioning it, applied closing iterator
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
