saithal-confluent commented on code in PR #19598:
URL: https://github.com/apache/druid/pull/19598#discussion_r3440263366
##########
server/src/main/java/org/apache/druid/server/DruidNode.java:
##########
@@ -139,7 +157,8 @@ public DruidNode(
@JacksonInject(useInput = OptBoolean.TRUE) @Named("tlsServicePort")
@JsonProperty("tlsPort") Integer tlsPort,
@JsonProperty("enablePlaintextPort") Boolean enablePlaintextPort,
@JsonProperty("enableTlsPort") boolean enableTlsPort,
- @JsonProperty("labels") @Nullable Map<String, String> labels
+ @JsonProperty("labels") @Nullable Map<String, String> labels,
+ @JsonProperty("advertisedPlaintextPort") Integer advertisedPlaintextPort
Review Comment:
Restored the 9-arg overload so existing call sites keep compiling. The new
field is reachable via the 10-arg constructor instead of 9-arg one as it would
make existing null-literal calls ambiguous.
Thanks for the review @FrankChen021 , could you please take a look again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
