jtuglu1 commented on code in PR #19613: URL: https://github.com/apache/druid/pull/19613#discussion_r3457938708
########## processing/src/main/java/org/apache/druid/query/QueryContexts.java: ########## @@ -126,6 +126,7 @@ public class QueryContexts public static final String NO_PROJECTIONS = "noProjections"; public static final String FORCE_PROJECTION = "forceProjections"; public static final String USE_PROJECTION = "useProjection"; + public static final String PROJECTION_TRACE = "projectionTrace"; Review Comment: > i wonder if instead of adding a new flag if this should just check ENABLE_DEBUG context flag +1 to this. IMO, we should minimize the # of possible query context configuration combinations (there are frankly so many, some of which are documented and others not). My opinion: a user seeking debug information about a particular query should not need to go enable multiple query context flags to get the information they are looking for, _especially._ if they do not know what they are looking for. For debug, I'd rather get the kitchen sink and then filter myself manually. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
