FrankChen021 commented on code in PR #19522:
URL: https://github.com/apache/druid/pull/19522#discussion_r3459605296
##########
website/package.json:
##########
@@ -1,43 +1,38 @@
{
"license": "Apache-2.0",
"scripts": {
- "examples": "docusaurus-examples",
"start": "docusaurus start",
"build": "docusaurus build",
- "publish-gh-pages": "docusaurus-publish",
- "write-translations": "docusaurus-write-translations",
- "version": "docusaurus-version",
- "rename-version": "docusaurus-rename-version",
"compile-scss": "sass scss/custom.scss > static/css/custom.css",
"link-lint": "node script/link-lint.js",
"spellcheck": "mdspell --en-us --ignore-numbers --report '../docs/**/*.md'
|| (./script/notify-spellcheck-issues && false)",
"swizzle": "docusaurus swizzle",
- "deploy": "docusaurus deploy",
"docusaurus": "docusaurus",
"clear": "docusaurus clear"
},
"engines": {
- "node": ">=18.0"
+ "node": ">=22.0"
},
"volta": {
- "node": "18.20.7",
+ "node": ">=22.0",
Review Comment:
[P3] Pin Volta to a concrete Node release
The `volta.node` field is a project pin, not an npm engine range. The
previous value was a concrete version and the sibling
`web-console/package.json` still pins an exact Node version, so `>=22.0` can
prevent Volta-managed contributors from selecting/installing the website Node
runtime correctly. Keep `engines.node` as the range if desired, but set
`volta.node` to an actual Node 22.x release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
