Fly-Style commented on code in PR #19622:
URL: https://github.com/apache/druid/pull/19622#discussion_r3473226190
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/autoscaler/CostBasedAutoScaler.java:
##########
@@ -85,6 +87,16 @@ public class CostBasedAutoScaler implements
SupervisorTaskAutoScaler
private final CostBasedAutoScalerConfig config;
private final ScheduledExecutorService autoscalerExecutor;
private final WeightedCostFunction costFunction;
+ /**
+ * Recent {@code avgProcessingRate} readings, but only from ticks where lag
was present.
+ * "Lag-gated" because lag is the condition that decides whether a reading
counts as evidence
+ * of capacity at all: with no lag the task is only processing as fast as
data arrives (an
+ * upstream supply number, not a capacity number); with lag present, demand
isn't the
+ * bottleneck, so the rate observed is the task's own ceiling. The max of
these samples
+ * becomes {@link CostMetrics#getMaxObservedRate()}.
Review Comment:
Removed because it has been massively simplified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
