FrankChen021 commented on code in PR #19629:
URL: https://github.com/apache/druid/pull/19629#discussion_r3481284197
##########
licenses.yaml:
##########
@@ -2069,6 +2070,9 @@ notices:
- log4j-slf4j-impl: |
Apache Log4j SLF4J Binding
Copyright 1999-2015 Apache Software Foundation
+ - log4j-layout-template-json: |
+ Apache Log4j Layout Template JSON
Review Comment:
[P2] Correct the NOTICE text for the new Log4j layout jar
The newly added log4j-layout-template-json notice does not match the 2.26.0
jar's META-INF/NOTICE: the artifact identifies itself as `Apache Log4j JSON
Template Layout` and uses `Copyright 1999-2026 The Apache Software Foundation`,
while this entry says `Apache Log4j Layout Template JSON` and keeps the older
1999-2015 copyright. `distribution/bin/generate-binary-notice.py` copies these
notices into NOTICE.BINARY, so the binary release metadata for the newly
bundled jar would be inaccurate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]