leventov commented on a change in pull request #7206: Add the pull-request 
template
URL: https://github.com/apache/incubator-druid/pull/7206#discussion_r264860371
 
 

 ##########
 File path: .github/pull_request_template.md
 ##########
 @@ -0,0 +1,53 @@
+Fixes #XXXX.
+
+(Replace XXXX with the id of the issue fixed in this PR. Remove this line if 
there is no corresponding
+issue. Don't reference the issue in the title of this pull-request.)
+
+Add tags to your PR if you are a committer (only committers have the right to 
add tags). Add [Design Review] tag
+if this PR should better be reviewed by at least two people.
+Don't forget to add the following tags (if applicable): [Incompatible], 
[Release Notes], [Compatibility], [Security],
 
 Review comment:
   "Compatibility" is opposite of "Incompatible": it restores or ensures 
compatibility in some way. See [this message in dev 
list](https://groups.google.com/d/msg/druid-development/C_hSrl6nCvQ/tQBTOjguAwAJ).
   
   I've started explaining tags in the "PR Management" section in the [draft of 
a common 
checklist](https://docs.google.com/document/d/17EEKT6fih9Dd5NfXjBoECcKbVp1eOB2vb3jKqTF9pPc/edit).
 Now I don't think this checklist should exist as a giant whole. Better to 
split it into smaller, more focused checklists.
   
   "PR Management" section from the document above should be extracted as "PR 
action items checklist for a committer". (I don't plan to do this task myself 
in the very immediate future.)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to