Fly-Style commented on code in PR #19641:
URL: https://github.com/apache/druid/pull/19641#discussion_r3503763585
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/autoscaler/CostBasedAutoScaler.java:
##########
@@ -295,10 +297,18 @@ int computeOptimalTaskCount(CostMetrics metrics)
}
emitter.emit(getMetricBuilder().setMetric(OPTIMAL_TASK_COUNT_METRIC,
(long) optimalTaskCount));
- emitter.emit(getMetricBuilder().setMetric(LAG_WEIGHT_METRIC,
optimalCost.lagCost()));
- emitter.emit(getMetricBuilder().setMetric(IDLE_WEIGHT_METRIC,
optimalCost.idleCost()));
- emitter.emit(getMetricBuilder().setMetric(AVG_PROCESSING_RATE_METRIC,
metrics.getAvgProcessingRate()));
- emitter.emit(getMetricBuilder().setMetric(AVG_POLL_IDLE_RATIO,
metrics.getPollIdleRatio()));
+ emitter.emit(getMetricBuilder().setMetric(LAG_WEIGHT_METRIC,
config.getLagWeight()));
+ emitter.emit(getMetricBuilder().setMetric(IDLE_WEIGHT_METRIC,
config.getIdleWeight()));
+ emitter.emit(getMetricBuilder().setMetric(LAG_COST_METRIC,
optimalCost.lagCost()));
+ emitter.emit(getMetricBuilder().setMetric(IDLE_COST_METRIC,
optimalCost.idleCost()));
+
+ // Emit avg rate and idle metrics only if they are available
+ if (metrics.getAvgProcessingRate() >= 0) {
+ emitter.emit(getMetricBuilder().setMetric(AVG_PROCESSING_RATE_METRIC,
metrics.getAvgProcessingRate()));
+ }
+ if (metrics.getPollIdleRatio() >= 0) {
+ emitter.emit(getMetricBuilder().setMetric(AVG_POLL_IDLE_RATIO,
metrics.getPollIdleRatio()));
+ }
Review Comment:
I'd also would like to request you to emit
`estimateIdleRatioFromProcessingRate()` as separate metric for better tracking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
