kfaraz commented on code in PR #19648:
URL: https://github.com/apache/druid/pull/19648#discussion_r3510683784
##########
server/src/main/java/org/apache/druid/client/CachingClusteredClient.java:
##########
@@ -345,6 +345,19 @@ ClusterQueryResult<T> run(
}
final Set<SegmentServerSelector> segmentServers =
computeSegmentsToQuery(timeline, specificSegments);
+ log.info("Query[%s] found [%d] segments from timeline lookup.",
query.getId(), segmentServers.size());
Review Comment:
> we also don't have datasegment here, this is really cropped segment
descriptor.
The `SegmentDescriptor` is the same as the `SegmentId` minus the datasource.
We already have the datasource name here (`ev.getBaseTableDataSource()`)
which is used to extract the timeline in preceding lines.
We should convert all descriptors to `SegmentId` and add a new method
`Logger.debugSegmentIds` similar to `Logger.infoSegmentIds`, if needed or we
can just use `infoSegmentIds` itself if we are gating this on
`query.context().isDebug()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
