kfaraz commented on code in PR #19668:
URL: https://github.com/apache/druid/pull/19668#discussion_r3548905192
##########
services/src/test/java/org/apache/druid/server/AsyncQueryForwardingServletTest.java:
##########
@@ -967,12 +973,53 @@ protected void doService(
stubServiceEmitter.getMetricEvents("query/time").get(0).toMap().get(DruidMetrics.STATUS_CODE)
);
}
+ if (!isJDBCSql) {
+ assertStatusCodeMatchesMetric(requestLogger, isNativeSql,
getEmittedStatusCode(stubServiceEmitter));
+ }
// This test is mostly about verifying that the servlet calls the right
methods the right number of times.
EasyMock.verify(hostFinder, requestMock);
Assert.assertEquals(1, didService.get());
}
+ private static int getEmittedStatusCode(StubServiceEmitter
stubServiceEmitter)
+ {
+ return (int)
stubServiceEmitter.getMetricEvents("query/time").get(0).toMap().get(DruidMetrics.STATUS_CODE);
+ }
+
+ private static void assertStatusCodeMatchesMetric(
+ RequestLogger requestLogger,
+ boolean isSqlQuery,
+ int metricStatusCode
+ ) throws IOException
+ {
+ if (isSqlQuery) {
Review Comment:
Seems like this method is always being called for SQL queries only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
