kfaraz commented on code in PR #19651: URL: https://github.com/apache/druid/pull/19651#discussion_r3550043772
########## indexing-service/src/main/java/org/apache/druid/indexing/common/SegmentUpgradeMetrics.java: ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.indexing.common; + +/** + * Metric names and dimension values for the re-announcement of pending segments upgraded by a concurrent REPLACE. + * <ul> + * <li>the task action emits {@link #COUNT} (how many upgrades a commit produced),</li> + * <li>the supervisor emits {@link #NOTIFIED}, {@link #UNMATCHED} and {@link #SEND_FAILED} as it fans requests out,</li> + * <li>the streaming task emits {@link #ANNOUNCED} and {@link #SKIPPED} (with a {@code reason}) as it applies them.</li> + * </ul> + * Comparing {@link #COUNT} (created) against {@link #ANNOUNCED} (applied) per dataSource quantifies the visibility gap; + * {@link #UNMATCHED}, {@link #SEND_FAILED} and {@link #SKIPPED} attribute where a lost upgrade dropped out. + */ +public class SegmentUpgradeMetrics +{ + /** Number of upgraded pending segments a REPLACE commit created and handed to the supervisor. Task-action dims. */ + public static final String COUNT = "ingest/segmentUpgrade/count"; + + /** A record was delivered to at least one running task. Supervisor dims. */ + public static final String NOTIFIED = "ingest/segmentUpgrade/notified"; Review Comment: ```suggestion public static final String REALTIME_TASK_NOTIFIED = "ingest/realtime/segmentUpgrade/notified"; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
