capistrant commented on code in PR #19511: URL: https://github.com/apache/druid/pull/19511#discussion_r3554098939
########## indexing-service/src/main/java/org/apache/druid/indexing/compact/ReindexingTimelineView.java: ########## @@ -0,0 +1,460 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.indexing.compact; + +import com.fasterxml.jackson.annotation.JsonCreator; +import com.fasterxml.jackson.annotation.JsonInclude; +import com.fasterxml.jackson.annotation.JsonProperty; +import com.fasterxml.jackson.annotation.JsonSubTypes; +import com.fasterxml.jackson.annotation.JsonTypeInfo; +import org.apache.druid.server.compaction.ReindexingDataSchemaRule; +import org.apache.druid.server.compaction.ReindexingDeletionRule; +import org.apache.druid.server.compaction.ReindexingIndexSpecRule; +import org.apache.druid.server.compaction.ReindexingPartitioningRule; +import org.apache.druid.server.compaction.ReindexingRule; +import org.apache.druid.server.coordinator.DataSourceCompactionConfig; +import org.joda.time.DateTime; +import org.joda.time.Interval; +import org.joda.time.Period; + +import javax.annotation.Nullable; +import java.util.ArrayList; +import java.util.Collections; +import java.util.List; +import java.util.Objects; + +/** + * Public API DTO describing the timeline of search intervals and their associated reindexing + * configurations for a cascading reindexing supervisor. Surfaced through the + * {@code /supervisor/{id}/reindexingTimeline} endpoint so operators (and the web console) + * can visualize how rules are applied across time. + * + * <p>Always produced via {@link #fromPlan(ReindexingPlan)} so the API view is a pure projection + * of the same plan that drives job creation — the two cannot drift. + */ +public class ReindexingTimelineView +{ + private final String dataSource; + private final DateTime referenceTime; + @Nullable + private final SkipOffsetInfo skipOffset; + private final List<IntervalConfig> intervals; + @Nullable + private final ValidationError validationError; + + @JsonCreator + public ReindexingTimelineView( Review Comment: I think ReindexingPlanResponse is solid, thanks for the suggestion -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
