clintropolis commented on code in PR #19671:
URL: https://github.com/apache/druid/pull/19671#discussion_r3561424892
##########
server/src/main/java/org/apache/druid/segment/loading/SegmentLocalCacheManager.java:
##########
@@ -927,6 +1276,15 @@ public void load(final DataSegment dataSegment) throws
SegmentLoadingException
"load() should not be called when virtualStorageIsEphemeral is
true"
);
}
+ // Partial-load-rule routing: a wrapped load spec carrying a fingerprint
+ per-spec selection (cluster groups,
+ // projections, ...) means the coordinator wants this segment loaded
with rule holds pinning the selected
+ // bundles + metadata. Install the holds via loadPartial; other segments
(no wrapper, or partials disabled)
+ // take the existing weak/no-op path below.
+ if (config.isVirtualStoragePartialDownloadsEnabled()
+ && PartialLoadSpec.detectPartialLoadSpec(dataSegment.getLoadSpec()))
{
+ loadPartial(dataSegment);
Review Comment:
I was planning to do this as a follow-up once this piece lands
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
