jtuglu1 commented on code in PR #19685:
URL: https://github.com/apache/druid/pull/19685#discussion_r3582852301
##########
server/src/main/java/org/apache/druid/metadata/SqlSegmentsMetadataQuery.java:
##########
@@ -1069,14 +1069,14 @@ public List<Interval> retrieveUnusedSegmentIntervals(
* guarantee on the order of intervals in the list or on whether the limited
* list contains the earliest or latest intervals present in the datasource.
*
- * @return List of unused segment intervals containing upto {@code limit}
entries.
+ * @return List of unused segment intervals containing upto {@code limit}
interval entries.
*/
public List<Interval> retrieveUnusedSegmentIntervals(String dataSource, int
limit)
{
final String sql = StringUtils.format(
"SELECT start, %2$send%2$s FROM %1$s"
+ " WHERE dataSource = :dataSource AND used = false"
- + " GROUP BY start, %2$send%2$s"
+ + " GROUP BY %2$send%2$s, start"
Review Comment:
could this implicitly change any ordering assumptions of the output?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
