kfaraz commented on code in PR #19687:
URL: https://github.com/apache/druid/pull/19687#discussion_r3585832812
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/supervisor/SupervisorResource.java:
##########
@@ -534,6 +535,50 @@ public Response terminateAll(@Context final
HttpServletRequest req)
);
}
+ @GET
+ @Path("/{id}/autoscaler")
+ @Produces(MediaType.APPLICATION_JSON)
+ @ResourceFilters(SupervisorResourceFilter.class)
+ public Response simulateAutoscalingWithLag(
+ @PathParam("id") String supervisorId,
+ @QueryParam("taskCountMin") int taskCountMin,
+ @QueryParam("taskCountMax") int taskCountMax,
+ @QueryParam("maxProcessingRatePerTask") int maxProcessingRatePerTask,
+ @QueryParam("optimalTaskIdleRatio") double optimalTaskIdleRatio,
+ @QueryParam("criticalLag") int criticalLag,
Review Comment:
Instead of multiple query params, we should just be able to send a POST
payload object as a `CostBasedAutoScalerConfig`.
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/supervisor/SupervisorResource.java:
##########
@@ -534,6 +535,50 @@ public Response terminateAll(@Context final
HttpServletRequest req)
);
}
+ @GET
+ @Path("/{id}/autoscaler")
Review Comment:
We will rename this API based on what we decide the final result set to look
like:
```suggestion
@Path("/{id}/autoscaler/simulate")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
