ektravel commented on code in PR #19684: URL: https://github.com/apache/druid/pull/19684#discussion_r3590195852
########## docs/development/extensions-contrib/druid-ranger-security.md: ########## @@ -22,7 +22,7 @@ title: "Apache Ranger Security" ~ under the License. --> -This Apache Druid extension adds an Authorizer which implements access control for Druid, backed by [Apache Ranger](https://ranger.apache.org/). Please see [Authentication and Authorization](../../operations/auth.md) for more information on the basic facilities this extension provides. +This Apache Druid extension adds an Authorizer which implements access control for Druid, backed by [Apache® Ranger](https://ranger.apache.org/). Please see [Authentication and Authorization](../../operations/auth.md) for more information on the basic facilities this extension provides. Review Comment: ```suggestion This Apache® Druid extension adds an Authorizer which implements access control for Druid using [Apache® Ranger](https://ranger.apache.org/). See [Authentication and authorization](../../operations/auth.md) for more information. ``` ########## docs/development/extensions-contrib/iceberg.md: ########## @@ -27,7 +27,7 @@ to Apache Iceberg docs: https://github.com/apache/iceberg/blob/main/docs/mkdocs. ## Iceberg Ingest extension -Apache Iceberg is an open table format for huge analytic datasets. [IcebergInputSource](../../ingestion/input-sources.md#iceberg-input-source) lets you ingest data stored in the Iceberg table format into Apache Druid. To use the iceberg extension, add the `druid-iceberg-extensions` to the list of loaded extensions. See [Loading extensions](../../configuration/extensions.md#loading-extensions) for more information. +Apache® Iceberg is an open table format for huge analytic datasets. [IcebergInputSource](../../ingestion/input-sources.md#iceberg-input-source) lets you ingest data stored in the Iceberg table format into Apache Druid. To use the iceberg extension, add the `druid-iceberg-extensions` to the list of loaded extensions. See [Loading extensions](../../configuration/extensions.md#loading-extensions) for more information. Review Comment: ```suggestion Apache® Iceberg is an open table format for large analytic datasets. [IcebergInputSource](../../ingestion/input-sources.md#iceberg-input-source) lets you ingest data stored in the Iceberg table format into Apache Druid. To use the Iceberg extension, add the `druid-iceberg-extensions` to the list of loaded extensions. See [Loading extensions](../../configuration/extensions.md#loading-extensions) for more information. ``` ########## docs/development/extensions-core/kubernetes.md: ########## @@ -24,7 +24,7 @@ title: "Kubernetes" Consider this an [EXPERIMENTAL](../experimental.md) feature mostly because it has not been tested yet on a wide variety of long running Druid clusters. -Apache® Druid Extension to enable using Kubernetes API Server for node discovery and leader election. This extension allows Druid cluster deployment on Kubernetes without Zookeeper. It allows running multiple Druid clusters within same Kubernetes Cluster, See `clusterIdentifier` config below. +Apache® Druid Extension to enable using Kubernetes® API Server for node discovery and leader election. This extension allows Druid cluster deployment on Kubernetes without Zookeeper. It allows running multiple Druid clusters within same Kubernetes Cluster, See `clusterIdentifier` config below. Review Comment: ```suggestion Apache® Druid extension to enable using the Kubernetes® API Server for node discovery and leader election. This extension allows you to deploy a Druid cluster on Kubernetes without Zookeeper and run multiple Druid clusters within the same Kubernetes cluster. For more information, see the `clusterIdentifier` configuration below. ``` ########## docs/development/extensions-core/k8s-jobs.md: ########## @@ -350,7 +350,7 @@ The logic defining how the pod template is built for your Kubernetes Job depends ### Overlord Single Container Pod Adapter/Overlord Multi Container Pod Adapter The overlord single container pod adapter takes the podSpec of your `Overlord` pod and creates a kubernetes job from this podSpec. This is the default pod adapter implementation, to explicitly enable it you can specify the runtime property `druid.indexer.runner.k8s.adapter.type: overlordSingleContainer` -The overlord multi container pod adapter takes the podSpec of your `Overlord` pod and creates a kubernetes job from this podSpec. It uses kubexit to manage dependency ordering between the main container that runs your druid peon and other sidecars defined in the `Overlord` pod spec. Thus if you have sidecars such as Splunk or Istio it will be able to handle them. To enable this pod adapter you can specify the runtime property `druid.indexer.runner.k8s.adapter.type: overlordMultiContainer` +The overlord multi container pod adapter takes the podSpec of your `Overlord` pod and creates a kubernetes job from this podSpec. It uses kubexit to manage dependency ordering between the main container that runs your druid peon and other sidecars defined in the `Overlord` pod spec. Thus if you have sidecars such as Splunk® or Istio it will be able to handle them. To enable this pod adapter you can specify the runtime property `druid.indexer.runner.k8s.adapter.type: overlordMultiContainer` Review Comment: ```suggestion The Overlord multi-container pod adapter uses the pod specification of your Overlord pod to create a Kubernetes job. It uses kubexit to manage dependency ordering between the main container that runs your Druid peon and other sidecars defined in the Overlord pod specification. This allows the adapter to handle sidecars such Splunk® or Istio. To enable this pod adapter, set the runtime property `druid.indexer.runner.k8s.adapter.type: overlordMultiContainer`. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
