FrankChen021 commented on code in PR #19692:
URL: https://github.com/apache/druid/pull/19692#discussion_r3595289421
##########
web-console/src/views/supervisors-view/supervisors-view.tsx:
##########
@@ -1060,6 +1065,12 @@ export class SupervisorsView extends React.PureComponent<
aggregateLag,
)}`}</span>
) : null;
+ } else if (original.type === 'autocompact') {
Review Comment:
[P2] Handle autocompact type in the non-SQL fallback
On the non-SQL path above, each row's type is derived exclusively from
`sup.spec.tuningConfig.type`. A `CompactionSupervisorSpec` serializes its type
at `sup.spec.type` and its config at `sup.spec.spec`, so autocompact rows have
`original.type === undefined`; this new branch therefore never executes when
the console is pointed directly at an Overlord. Include `sup.spec.type` when
mapping fallback rows so Details works in this supported mode.
##########
web-console/src/views/supervisors-view/supervisors-view.tsx:
##########
@@ -1060,6 +1065,12 @@ export class SupervisorsView extends React.PureComponent<
aggregateLag,
)}`}</span>
) : null;
+ } else if (original.type === 'autocompact') {
+ if (!supervisorStatusPayload || !original.spec) return null;
+ return formatCompactionInfo({
+ status: supervisorStatusPayload,
+ config: original.spec as CompactionConfig,
Review Comment:
[P2] Pass the nested compaction config
`original.spec` is the serialized supervisor wrapper (`{ type:
"autocompact", spec: DataSourceCompactionConfig, ... }`), not the compaction
config itself. Passing the wrapper makes `formatCompactionInfo` read
`skipOffsetFromLatest` and `inputSegmentSizeBytes` from the wrong level, so
fully compacted statuses with skipped segments always claim the default `P1D`
exclusion and omit any legacy segment-size exclusion. Pass `original.spec.spec`
instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
