FrankChen021 commented on code in PR #19532:
URL: https://github.com/apache/druid/pull/19532#discussion_r3595344321
##########
server/src/main/java/org/apache/druid/server/coordinator/loading/StrategicSegmentAssigner.java:
##########
@@ -86,6 +87,7 @@ public StrategicSegmentAssigner(
this.cluster = cluster;
this.strategy = strategy;
this.loadQueueManager = loadQueueManager;
+ this.allTiersInCluster = Set.copyOf(cluster.getTierNames());
Review Comment:
[P2] Preserve null tier handling in the cached set
`DruidCluster.Builder.addTier` and `DruidServerMetadata` both permit a null
tier, and the previous `HashSet` copy preserved such a key. `Set.copyOf`
rejects null elements, so one Historical with a null or omitted tier now throws
here and aborts the HistoricalManagement duty before replica assignment. Use a
null-tolerant copy, or normalize or reject null when constructing the cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
