clintropolis commented on code in PR #19693:
URL: https://github.com/apache/druid/pull/19693#discussion_r3599810993
##########
processing/src/main/java/org/apache/druid/segment/file/PartialSegmentFileMapperV10.java:
##########
@@ -458,7 +465,16 @@ public ByteBuffer mapFile(String name) throws IOException
return null;
}
- ensureFileDownloaded(name, fileMetadata);
+ // Mapping never downloads, every caller is expected to have made the file
resident through an explicit plan before
+ // reading it
+ if (!downloadedFiles.contains(name)) {
Review Comment:
while fixing this, also noticed a flaw in `PartialQueryableIndex` that the
column holder suppliers are memoized, but do not consider if their underlying
bundles have/have not been evicted, so added some 'generation' tracking for the
bundles and special suppliers that can check if they were created for the
current generation or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
