clintropolis commented on code in PR #19658:
URL: https://github.com/apache/druid/pull/19658#discussion_r3606327515
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/SegmentCacheManagerFactory.java:
##########
@@ -77,11 +107,10 @@ public SegmentCacheManager manufacturate(File storageDir,
Long maxSize, boolean
.setVirtualStorage(virtualStorage)
.setVirtualStorageIsEphemeral(virtualStorage);
final List<StorageLocation> storageLocations =
loaderConfig.toStorageLocations();
- final StorageLoadingThreadPool loadingThreadPool =
StorageLoadingThreadPool.createFromConfig(loaderConfig);
return new SegmentLocalCacheManager(
storageLocations,
loaderConfig,
- loadingThreadPool,
+ virtualStorage ? loadingThreadPoolProvider.get() :
StorageLoadingThreadPool.none(),
Review Comment:
i just removed this from the lifecycle and marked it lazy singleton instead,
which I think should be ok as I would expect nothing to be running on the pool
by the time of shutdown since all of the threads running things that could be
using it will have been stopped by the time of process exit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
