jaykanakiya commented on code in PR #19704:
URL: https://github.com/apache/druid/pull/19704#discussion_r3619593291
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskRunner.java:
##########
@@ -747,13 +755,17 @@ public void run()
dim,
k -> Collections.synchronizedSet(new HashSet<>())
);
- // Empty getDimension result means a null/missing value;
record null so IS NULL is not pruned
- // (distinct from "", which getDimension returns as [""
]).
- final List<String> dimValues = row.getDimension(dim);
- if (dimValues == null || dimValues.isEmpty()) {
- dimSet.add(null);
+ if (longPartitionDimensions.contains(dim)) {
+ dimSet.add(canonicalLongValue(row.getRaw(dim), dim));
Review Comment:
Fixed so that long dims now skip the string/range channel and prune only via
the type-gated possibleInValueDomain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
