FrankChen021 commented on code in PR #19707:
URL: https://github.com/apache/druid/pull/19707#discussion_r3622004620
##########
pom.xml:
##########
@@ -70,7 +70,7 @@
</scm>
<properties>
- <java.version>21</java.version>
+ <java.version>25</java.version>
Review Comment:
[P1] Make the packaged launcher accept JDK 25
The distribution still bundles and invokes `examples/bin/verify-java` before
normal startup, but that script rejects every version except 17 and 21. A user
running the newly required JDK 25 therefore exits before Druid starts unless
they bypass the check manually. Update the verifier, its error text, and the
runtime documentation as part of the compiler upgrade.
##########
.github/workflows/ci.yml:
##########
@@ -24,7 +24,7 @@ jobs:
strategy:
fail-fast: false
matrix:
- jdk: [ "21", "25" ]
+ jdk: [ "25" ]
Review Comment:
[P1] Upgrade the scheduled security scan to JDK 25
`.github/workflows/cron-job-its.yml` still installs JDK 21 before running
`mvn clean install`. Once this POM requires `--release 25`, that build fails
before the daily OWASP dependency scan can execute. Update the scheduled
workflow to JDK 25 along with the main CI matrix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
