kfaraz commented on code in PR #19737:
URL: https://github.com/apache/druid/pull/19737#discussion_r3640878801
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/KillUnusedSegmentsTask.java:
##########
@@ -387,13 +434,12 @@ private NavigableMap<DateTime, List<TaskLock>>
getNonRevokedTaskLockMap(TaskActi
* @return list of segments to kill from deep storage
*/
private List<DataSegment> getKillableSegments(
- List<DataSegment> unusedSegments,
+ Set<DataSegment> unusedSegments,
Review Comment:
Since this method is now invoked before metadata entries have been nuked, it
should exclude self segment ID while doing the sibling check.
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/KillUnusedSegmentsTask.java:
##########
@@ -387,13 +434,12 @@ private NavigableMap<DateTime, List<TaskLock>>
getNonRevokedTaskLockMap(TaskActi
* @return list of segments to kill from deep storage
*/
private List<DataSegment> getKillableSegments(
- List<DataSegment> unusedSegments,
+ Set<DataSegment> unusedSegments,
Review Comment:
TODO: Since this method is now invoked before metadata entries have been
nuked, it should exclude self segment ID while doing the sibling check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
