jtuglu1 commented on code in PR #19738: URL: https://github.com/apache/druid/pull/19738#discussion_r3641414211
########## docs/configuration/index.md: ########## @@ -1019,6 +1019,7 @@ If autoscaling is enabled, you can set these additional configs: |`druid.supervisor.maxStoredExceptionEvents`|The maximum number of exception events that can be returned through the supervisor `/status` endpoint.|`max(healthinessThreshold, unhealthinessThreshold)`| |`druid.supervisor.idleConfig.enabled`|If `true`, supervisor can become idle if there is no data on input stream/topic for some time.|false| |`druid.supervisor.idleConfig.inactiveAfterMillis`|Supervisor is marked as idle if all existing data has been read from input topic and no new data has been published for `inactiveAfterMillis` milliseconds.|`600_000`| +|`druid.supervisor.maxWorkerThreads`|Upper bound on the number of worker threads a stream supervisor derives automatically for interacting with its tasks. Defaults to unbounded (the derived value is used as-is); setting `workerThreads` explicitly in the supervisor `tuningConfig` bypasses both the derivation and this cap.|`2147483647` (unbounded)| Review Comment: I'm not actually sure what would happen; these default values seem pretty arbitrary. That being said, the default `MIN_WORKER_CORE_THREADS=2`, so perhaps I can stick some validation in there for this config to be no less than that. In general, seems like `DEFAULT_TASKS_PER_WORKER_THREAD=4`, so you'd conceivably only be able to scale to 4 tasks without some sort of perf degradation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
