FrankChen021 commented on code in PR #19741:
URL: https://github.com/apache/druid/pull/19741#discussion_r3645236731
##########
web-console/src/utils/sampler.ts:
##########
@@ -285,6 +287,14 @@ export async function sampleForConnect(
);
}
+ const addFileUri = Boolean(
+ ioConfig.inputSource &&
+
getPossibleSystemFieldsForInputSource(ioConfig.inputSource).includes('__file_uri'),
Review Comment:
[P2] Include HTTP sources in the file-URI gate
`getPossibleSystemFieldsForInputSource` returns no fields for `http`, even
though `HttpInputSource` supports both `__file_uri` and `__file_path`. As a
result this new gate never requests `__file_uri` for HTTP samples, so the
tooltip is absent for the web console's common URL-based sample flow. Add HTTP
to the supported-source mapping and cover the generated sampler request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
