clintropolis commented on code in PR #19746:
URL: https://github.com/apache/druid/pull/19746#discussion_r3648963041
##########
server/src/main/java/org/apache/druid/segment/loading/PartialSegmentMetadataCacheEntry.java:
##########
@@ -666,13 +668,7 @@ public long getRealizedBytes()
@Override
public boolean isMounted()
{
- entryLock.lock();
- try {
- return fileMapper != null;
- }
- finally {
- entryLock.unlock();
- }
+ return fileMapper != null;
Review Comment:
hmm, i think we need to flip where we assign `fileMapper` in `doMount` with
the line right after where we set `references` to the new reference counter so
there isn't a window where isMounted is true but the reference counter isn't
available. Same thing with `PartialSegmentBundleCacheEntry` I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
