clintropolis commented on a change in pull request #7256: fix SequenceMetadata
deserialization
URL: https://github.com/apache/incubator-druid/pull/7256#discussion_r265292852
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskRunner.java
##########
@@ -508,6 +504,7 @@ public void run()
if (isEndSequenceOffsetsExclusive() &&
createSequenceNumber(record.getSequenceNumber()).compareTo(
createSequenceNumber(endOffsets.get(record.getPartitionId()))) >= 0) {
+ stillReading = false;
Review comment:
Oops, yes I have a test case to replicate this, I ended up modifying the
test to not hit the condition anymore before I determined the issue, will add
the test back. This was an attempt to fix opportunistically after choosing a
test case that happened to hit the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
