FrankChen021 commented on code in PR #19774:
URL: https://github.com/apache/druid/pull/19774#discussion_r3665377578
##########
web-console/src/views/workbench-view/run-panel/run-panel.tsx:
##########
@@ -565,6 +565,10 @@ export const RunPanel = React.memo(function
RunPanel(props: RunPanelProps) {
...queryContext,
useCache,
populateCache: useCache,
+ useResultLevelCache: useCache,
+ populateResultLevelCache: useCache,
+ useForwardedResultLevelCache: useCache,
Review Comment:
[P2] Do not emit unsupported forwarded-cache keys
These two forwarded result-level keys have no server-side consumer: their
only repository occurrences are the newly added UI/type fields, while Druid
reads only useResultLevelCache and populateResultLevelCache. They therefore
disable nothing. Additionally, when query-context authorization is enabled, SQL
treats each user-supplied key as a QUERY_CONTEXT resource, so toggling this
control can require permissions for meaningless keys and reject otherwise valid
queries. Remove them, or add actual server-side support if a separate forwarded
cache layer is intended.
##########
web-console/src/views/workbench-view/run-panel/run-panel.tsx:
##########
@@ -565,6 +565,10 @@ export const RunPanel = React.memo(function
RunPanel(props: RunPanelProps) {
...queryContext,
useCache,
populateCache: useCache,
+ useResultLevelCache: useCache,
Review Comment:
[P1] Normalize legacy disabled cache contexts
The new flags are written only after an onValueChange event. Queries saved
by the previous UI already contain useCache=false/populateCache=false but lack
these result-level keys; value={useCache} still displays Disabled, while
execution leaves both result-level flags absent. Druid defaults absent
useResultLevelCache/populateResultLevelCache values to true, so an enabled
broker result cache remains active. Normalize legacy disabled contexts or
submit false result-level flags whenever useCache is false, without requiring
users to toggle on and off again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
