FrankChen021 opened a new pull request, #19788: URL: https://github.com/apache/druid/pull/19788
## What changed Use `npm ci` instead of `npm install` when installing website dependencies in the web checks workflow. ## Why The repository commits `website/package-lock.json`, and Dependabot security updates can intentionally modify only that lockfile when updating a transitive dependency. `npm install` may reconcile or rewrite dependency resolution during CI, which means a passing build does not prove that the committed manifest and lockfile are consistent or that the exact locked dependency graph was tested. `npm ci` fails when `package.json` and `package-lock.json` disagree, installs the exact committed dependency graph, and does not rewrite the lockfile. This makes website dependency checks reproducible while leaving the local development workflow unchanged; developers can continue to use `npm install` when adding or updating dependencies. ## Validation - `bash -n .github/scripts/web-checks.sh` - `cd website && npm ci` - `npm run build` - `npm run link-lint` - `npm run spellcheck` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
