FrankChen021 commented on code in PR #19776:
URL: https://github.com/apache/druid/pull/19776#discussion_r3674249752


##########
docs/multi-stage-query/concepts.md:
##########
@@ -28,7 +28,7 @@ sidebar_label: "Key concepts"
 ## Multi-stage query task engine
 
 The MSQ task engine executes SQL statements as batch tasks in the indexing 
service, which execute on [Middle 
Managers](../design/architecture.md#druid-services).
-[INSERT](reference.md#insert) and [REPLACE](reference.md#replace) tasks 
publish [segments](../design/storage.md) just like [all other forms of batch 
ingestion](../ingestion/index.md#batch). Each query occupies at least two task 
slots while running: one controller task, and at least one worker task. As an 
experimental feature, the MSQ task engine also supports running SELECT queries 
as batch tasks. The behavior and result format of plain SELECT (without INSERT 
or REPLACE) is subject to change.
+[INSERT](reference.md#insert) and [REPLACE](reference.md#replace) tasks 
publish [segments](../design/storage.md) just like [all other forms of batch 
ingestion](../ingestion/index.md#batch). Each query occupies at least two task 
slots while running: one controller task, and at least one worker task. The MSQ 
task engine also supports running SELECT queries as batch tasks. The behavior 
and result format of plain SELECT (without INSERT or REPLACE) is subject to 
change.

Review Comment:
   [P2] Keep SELECT stability status consistent with the API docs
   
   The same plain-SELECT task behavior is still explicitly described as 
experimental in `docs/api-reference/sql-ingestion-api.md` at lines 51 and 300, 
including the identical result-format caveat. After this edit, users following 
this paragraph's `/druid/v2/sql/task` link receive conflicting stability claims 
for one capability. If SELECT tasks are being graduated, update both API 
references in this PR; otherwise retain the qualifier here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to