FrankChen021 opened a new pull request, #19826: URL: https://github.com/apache/druid/pull/19826
## What - fix all six format calls that supplied unused arguments - preserve `IOException` causes in `ForkingTaskRunner` - move 12 SQL lexer actions into JavaCC's common-token hook - keep generated lexer behavior unchanged while avoiding misleading generated indentation ## Why This group contains 20 CodeQL warnings: - 6 `java/unused-format-argument` - 14 `java/misleading-indentation` This PR directly addresses all six format warnings and 12 of the 14 generated indentation warnings. ## Generator limitation The remaining two warnings are emitted by JavaCC 4.0's own `getNextToken()` template around lexical-state transitions. They cannot be changed from Druid's grammar. Upgrading to JavaCC 7.0.13 was evaluated, but it produced a large generated diff, compilation incompatibilities, and parser error-message behavior changes while retaining these two sites. ## Impact Exceptions now include the intended causes and values. SQL lexer state transitions retain the same token images, kinds, special-token chains, and resulting states. ## Checks - affected-module compilation and Checkstyle passed - formatting-focused tests: 47 passed - SQL parser/unparser tests: 23 passed - original and generated common-token lexers matched in 12/12 targeted scenarios - parser regeneration completed with zero errors - `git diff --check` Created by GPT-5.6-Sol. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
