github-advanced-security[bot] commented on code in PR #19823:
URL: https://github.com/apache/druid/pull/19823#discussion_r3684674697
##########
indexing-service/src/test/java/org/apache/druid/indexing/common/task/batch/parallel/RangePartitionMultiPhaseParallelIndexingTest.java:
##########
@@ -454,16 +454,17 @@
Assert.assertTrue(shardSpec.toString(), start != null || end != null);
for (StringTuple value : values) {
+ if (value == null) {
+ Assert.assertNull("null values should be in first partition", start);
+ continue;
+ }
+
if (start != null) {
Assert.assertThat(value.compareTo(start),
Matchers.greaterThanOrEqualTo(0));
}
if (end != null) {
- if (value == null) {
- Assert.assertNull("null values should be in first partition", start);
- } else {
- Assert.assertThat(value.compareTo(end), Matchers.lessThan(0));
- }
+ Assert.assertThat(value.compareTo(end), Matchers.lessThan(0));
Review Comment:
## CodeQL / Deprecated method or constructor invocation
Invoking [Assert.assertThat](1) should be avoided because it has been
deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11431)
##########
extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisor.java:
##########
@@ -145,7 +145,7 @@
@Override
protected int getTaskGroupIdForPartition(KafkaTopicPartition partitionId)
{
- Integer taskCount = spec.getIoConfig().getTaskCount();
+ final int taskCount = spec.getIoConfig().getTaskCount();
Review Comment:
## CodeQL / Deprecated method or constructor invocation
Invoking [KafkaSupervisorSpec.getIoConfig](1) should be avoided because it
has been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11430)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
