This is an automated email from the ASF dual-hosted git repository.
cryptoe pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git
The following commit(s) were added to refs/heads/master by this push:
new b5599ba130d minor: Better message for redirect to unknown URL. (#19832)
b5599ba130d is described below
commit b5599ba130d759e20d53e1339630388504a474f3
Author: Gian Merlino <[email protected]>
AuthorDate: Thu Jul 30 14:32:48 2026 -0700
minor: Better message for redirect to unknown URL. (#19832)
The most common reason for the ServiceClientImpl to reject a redirect
to an unknown URL is that there is a leader failover currently in
progress. This patch updates the message to mention this possibility.
---
.../org/apache/druid/rpc/ServiceClientImpl.java | 38 +++++++++++++++-------
1 file changed, 26 insertions(+), 12 deletions(-)
diff --git a/server/src/main/java/org/apache/druid/rpc/ServiceClientImpl.java
b/server/src/main/java/org/apache/druid/rpc/ServiceClientImpl.java
index ca7ae0371c6..251988ff8d0 100644
--- a/server/src/main/java/org/apache/druid/rpc/ServiceClientImpl.java
+++ b/server/src/main/java/org/apache/druid/rpc/ServiceClientImpl.java
@@ -27,6 +27,7 @@ import com.google.common.util.concurrent.FutureCallback;
import com.google.common.util.concurrent.Futures;
import com.google.common.util.concurrent.ListenableFuture;
import com.google.common.util.concurrent.SettableFuture;
+import org.apache.druid.discovery.NodeRole;
import org.apache.druid.java.util.common.Either;
import org.apache.druid.java.util.common.IAE;
import org.apache.druid.java.util.common.StringUtils;
@@ -81,6 +82,15 @@ public class ServiceClientImpl implements ServiceClient
}
}
+ @VisibleForTesting
+ public static long computeBackoffMs(final ServiceRetryPolicy retryPolicy,
final long attemptNumber)
+ {
+ return Math.max(
+ retryPolicy.minWaitMillis(),
+ Math.min(retryPolicy.maxWaitMillis(), (long) (Math.pow(2,
attemptNumber) * retryPolicy.minWaitMillis()))
+ );
+ }
+
@Override
public <IntermediateType, FinalType> ListenableFuture<FinalType>
asyncRequest(
final RequestBuilder requestBuilder,
@@ -362,9 +372,9 @@ public class ServiceClientImpl implements ServiceClient
final long backoffMs = computeBackoffMs(retryPolicy,
attemptNumber);
log.info(
- "Service [%s] issued redirect to unknown URL [%s] on
attempt #%d; retrying in %,d ms.",
+ "Service [%s] %s on attempt #%d; retrying in %,d
ms.",
serviceName,
- newUri,
+ unknownRedirectTargetMessage(newUri),
nextAttemptNumber,
backoffMs
);
@@ -376,11 +386,7 @@ public class ServiceClientImpl implements ServiceClient
);
} else {
retVal.setException(
- new ServiceNotAvailableException(
- serviceName,
- "issued redirect to unknown URL [%s]",
- newUri
- )
+ new ServiceNotAvailableException(serviceName, "%s",
unknownRedirectTargetMessage(newUri))
);
}
}
@@ -487,12 +493,20 @@ public class ServiceClientImpl implements ServiceClient
return errorMessage.toString();
}
- @VisibleForTesting
- public static long computeBackoffMs(final ServiceRetryPolicy retryPolicy,
final long attemptNumber)
+ /**
+ * Generates the message used by logs or errors that occur due to
redirection to an unknown URL.
+ */
+ private String unknownRedirectTargetMessage(final String newUri)
{
- return Math.max(
- retryPolicy.minWaitMillis(),
- Math.min(retryPolicy.maxWaitMillis(), (long) (Math.pow(2,
attemptNumber) * retryPolicy.minWaitMillis()))
+ // Standard service names used by ServiceClientModule. If we are a client
for one of these services, we'll include
+ // some language about how this redirect can indicate a failover in
progress.
+ final boolean isOverlordOrCoordinator =
+ NodeRole.OVERLORD.getJsonName().equals(serviceName) ||
NodeRole.COORDINATOR.getJsonName().equals(serviceName);
+
+ return StringUtils.format(
+ "issued redirect to unknown URL [%s]%s",
+ newUri,
+ isOverlordOrCoordinator ? " (can be leader failover in progress)" : ""
);
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
