clintropolis commented on a change in pull request #7267: Logic adjustments to SeekableStreamIndexTaskRunner. URL: https://github.com/apache/incubator-druid/pull/7267#discussion_r265743663
########## File path: extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/IncrementalPublishingKafkaIndexTaskRunner.java ########## @@ -84,7 +84,7 @@ public IncrementalPublishingKafkaIndexTaskRunner( } @Override - protected Long getSequenceNumberToStoreAfterRead(@NotNull Long sequenceNumber) + protected Long getNextStartOffset(@NotNull Long sequenceNumber) Review comment: :+1 on switching to 'offset', i think it's more intuitive terminology, though maybe change parameter variable name too? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
