FrankChen021 commented on PR #19828: URL: https://github.com/apache/druid/pull/19828#issuecomment-5138390563
The line-level suppression was still not recognized. I inspected CodeQL Java AlertSuppressionAnnotations.ql: annotations on Callable elements explicitly cover the callable body, whereas the local-variable annotation uses only the declaration location and did not cover this path alert inside the initializer. I therefore moved only the CodeQL rule suppression to decrypt(), kept Error Prone InsecureCryptoUsage on the local Cipher declaration, and retained the legacy-compatibility justification. CryptoServiceTest passes 9/9, Maven validation succeeds, and git diff --check passes. Pushed as b57491db60; the PR remains draft while the new current-head pipeline runs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
