kfaraz commented on PR #19138: URL: https://github.com/apache/druid/pull/19138#issuecomment-5139025367
> I think configurable tolerance will be a useful feature to have, even though it isnt being used currently, such as if different tolerance were desired when tree size is large vs small. @pirvtech , fair enough, but please don't add methods or features which are currently not being used. We can always add it back if needed in the future. Same case for passing the comparators in the constructor of the `IntervalTreeMap`. Doing this makes it easy to understand why a certain a method or field exists in the first place. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
