clintropolis commented on issue #7267: Logic adjustments to SeekableStreamIndexTaskRunner. URL: https://github.com/apache/incubator-druid/pull/7267#issuecomment-473052402 >I think the best would be using different terms for kinesis and kafka. They are defining their own terminologies and this would be especially good for logging. I'm not sure what you mean... I think that would only be good for logging? I am mostly concerned about addressing what we call stuff in the code in the shared common structure to make it easy to follow and not switching what we call things all the time, and where I find offset to be more intuitive. I guess the implementors of `SeekableStreamIndexTaskRunner` could supply string labels of what terminology to use for topics and offsets to make the logs label things appropriately?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
